doc: update BUILDING.md #10669
Closed
doc: update BUILDING.md #10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code.
nodejs-github-bot
added
doc
mscdex
added
build
|
@nodejs/platform-windows @nodejs/documentation |
gibfahn
approved these changes
Jan 6, 2017
There was a problem hiding this comment.
LGTM (based on https://blogs.msdn.microsoft.com/vcblog/2015/07/24/setup-changes-in-visual-studio-2015-affecting-c-developers/), it'd be good to have someone from @nodejs/platform-windows weigh in as well.
jasnell
approved these changes
Jan 9, 2017
bzoz
approved these changes
Jan 9, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 10, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Landed in c9b52aa |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note about Visual Studio 2015 feature which should
be installed for building Node.js source code.